chore(infra): sst ebs option #3856
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Bencher Report| Branch | cesara/ebs_sst |
| Testbed | localhost |
Click to view all benchmark results
| Benchmark | File Size | Benchmark Result kilobytes (KB) (Result Δ%) | Upper Boundary kilobytes (KB) (Limit %) |
|---|---|---|---|
| zero-package.tgz | 📈 view plot 🚷 view threshold | 969.81 KB(+0.04%)Baseline: 969.38 KB | 988.77 KB (98.08%) |
| zero.js | 📈 view plot 🚷 view threshold | 180.29 KB(0.00%)Baseline: 180.29 KB | 183.89 KB (98.04%) |
| zero.js.br | 📈 view plot 🚷 view threshold | 50.10 KB(-0.04%)Baseline: 50.12 KB | 51.12 KB (98.00%) |
|
| Branch | cesara/ebs_sst |
| Testbed | localhost |
Click to view all benchmark results
| Benchmark | Throughput | Benchmark Result operations / second (ops/s) (Result Δ%) | Lower Boundary operations / second (ops/s) (Limit %) |
|---|---|---|---|
| src/client/zero.bench.ts > basics > All 1000 rows x 10 columns (numbers) | 📈 view plot 🚷 view threshold | 75.82 ops/s(+0.37%)Baseline: 75.54 ops/s | 70.31 ops/s (92.73%) |
| src/client/zero.bench.ts > with filter > Lower rows 500 x 10 columns (numbers) | 📈 view plot 🚷 view threshold | 101.88 ops/s(+8.72%)Baseline: 93.71 ops/s | 90.80 ops/s (89.13%) |
prod/sst/sst.config.ts
Outdated
|
|
||
| const addEbsVolumeConfig = ( | ||
| transform: any, | ||
| ecsVolumeRole: aws.iam.Role | undefined, |
There was a problem hiding this comment.
Since this is a lambda within the lexical scope of ecsVolumeRole, and the latter is essentially constant, I think you can just reference it instead of passing it in (thereby simplifying the callers).
prod/sst/sst.config.ts
Outdated
| ) => { | ||
| return { | ||
| ...transform, | ||
| service: IS_EBS_STAGE |
There was a problem hiding this comment.
I see how it's kind of tricky to recursively merge the stuff from the ebs volume.
However, we might be able to simplify this with the defu library which essentially does a recursive merge (we use this in our flags parser).
Although I don't think it will "merge" the taskDefinition function, we only define that once so I think it will do the right thing.
So ideally it can look something like:
const EBS_TRANSFORM = !IS_EBS_STAGE ? {} : {
service: {
volumneConfiguration: { ... },
},
taskDefinition: (args: any) => { ... },
};
// Then in the actual service definition:
const replicationManager = cluster.addService(`replication-manager`, {
...
transform: defu(EBS_TRANSFORM, {
service: {
healthCheckGracePeriodSeconds: 300, // same as health.startPeriod
},
....
}),
});Can you see if this would work? I think it would be make this easier to read and maintain.
| healthyThreshold: 2, | ||
| timeout: 3, | ||
| }, | ||
| ...BASE_TRANSFORM.target, |
There was a problem hiding this comment.
Does this work?
transform: defu(
{
target: {
stickiness: { ... }
}
},
EBS_TRANSFORM,
BASE_TRANSFORM,
);
No description provided.