feat(zero-pg): implement makeSchemaQuery to run queries on the server
#3818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
tantaman
commented
Feb 14, 2025
| queryProvider = makeSchemaQuery(schema); | ||
| }); | ||
|
|
||
| test('select', async () => { |
There was a problem hiding this comment.
this is just to test the plumbing. Tests of query forms (related/where/exists/etc.) are in z2s/test/chinook
tantaman
force-pushed
the
mlaw/zero-pg5
branch
from
6a812d1 to
c06b42f
Compare
|
Bencher Report| Branch | mlaw/zero-pg5 |
| Testbed | localhost |
Click to view all benchmark results
| Benchmark | File Size | Benchmark Result kilobytes (KB) (Result Δ%) | Upper Boundary kilobytes (KB) (Limit %) |
|---|---|---|---|
| zero-package.tgz | 📈 view plot 🚷 view threshold | 961.26(0.00%)Baseline: 961.26 | 980.49 (98.04%) |
| zero.js | 📈 view plot 🚷 view threshold | 180.39(0.00%)Baseline: 180.39 | 184.00 (98.04%) |
| zero.js.br | 📈 view plot 🚷 view threshold | 50.10(0.00%)Baseline: 50.10 | 51.11 (98.04%) |
arv
approved these changes
Feb 17, 2025
| } | ||
|
|
||
| async run(): Promise<HumanReadable<TReturn>> { | ||
| const sqlQuery = formatPg(compile(this._completeAst(), this.format)); |
There was a problem hiding this comment.
Should we cache this so we do not have to recompute it?
Comment on lines
+82
to
+85
| if (Array.isArray(result)) { | ||
| return result as HumanReadable<TReturn>; | ||
| } | ||
| return [...result] as HumanReadable<TReturn>; |
There was a problem hiding this comment.
Is this correct? How does this fit with one()?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.