Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

COO-483: feat: add "Enable cluster monitoring" checkbox to OCP console #628

Merged
merged 1 commit into from
Nov 18, 2024

Conversation

simonpasquier
Copy link
Contributor

This change adds the 'operatorframework.io/cluster-monitoring=true' annotation to the operator's CSV.

This change adds the 'operatorframework.io/cluster-monitoring=true'
annotation to the operator's CSV.

Signed-off-by: Simon Pasquier <[email protected]>
@simonpasquier simonpasquier requested a review from a team as a code owner November 18, 2024 09:46
@simonpasquier simonpasquier requested review from jan--f and PeterYurkovich and removed request for a team November 18, 2024 09:46
@simonpasquier simonpasquier changed the title feat: add "Enable cluster monitoring" checkbox to OCP console COO-483:feat: add "Enable cluster monitoring" checkbox to OCP console Nov 18, 2024
@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Nov 18, 2024

@simonpasquier: This pull request references COO-483 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.18.0" version, but no target version was set.

In response to this:

This change adds the 'operatorframework.io/cluster-monitoring=true' annotation to the operator's CSV.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@simonpasquier simonpasquier changed the title COO-483:feat: add "Enable cluster monitoring" checkbox to OCP console COO-483: feat: add "Enable cluster monitoring" checkbox to OCP console Nov 18, 2024
@openshift-ci openshift-ci bot requested review from periklis and slashpai November 18, 2024 09:46
Copy link

openshift-ci bot commented Nov 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: simonpasquier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

@marioferh marioferh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Nov 18, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 490a91d into rhobs:main Nov 18, 2024
11 checks passed
@simonpasquier simonpasquier deleted the COO-483 branch November 18, 2024 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants