Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(components): add a Markdown component #886

Merged
merged 30 commits into from
Jun 5, 2020
Merged

Conversation

zbaylin
Copy link
Member

@zbaylin zbaylin commented Jun 3, 2020

This uses omd's generic markdown parser to generate Markdown using Revery components.
image

To-do list:

  • Blocks:
    • Paragraph
    • List
    • Blockquote
    • Thematic break
    • Heading
    • Code block
    • HTML block (rendered as text)
    • ❌ Tag block
  • Inlines:
    • Text
    • Emph
    • Code
    • Hard break
    • Soft break
    • Link
    • Ref
    • HTML (rendered as text)
    • ❌ Tag

@zbaylin zbaylin added enhancement New feature or request WIP A-components Area: Consumer-exposed components providing some convenience over the primitives labels Jun 3, 2020
@github-actions
Copy link

github-actions bot commented Jun 3, 2020

I have updated your lock dirs and formatted the code.
Please @zbaylin pull the last commit before pushing any more changes.

@zbaylin zbaylin force-pushed the feat/components/markdown branch from 7f5c358 to 2fe1553 Compare June 3, 2020 19:44
@bryphe
Copy link
Member

bryphe commented Jun 3, 2020

So cool! Great use of the new FontFamily capabilities

@github-actions
Copy link

github-actions bot commented Jun 4, 2020

I have updated your lock dirs and formatted the code.
Please @zbaylin pull the last commit before pushing any more changes.

@zbaylin zbaylin requested a review from bryphe June 4, 2020 21:09
Copy link
Collaborator

@OhadRau OhadRau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really cool PR! Just figured I'd drop by and give some feedback since Zach has been showing me all the cool progress the past few days (and trying to keep up with the project since I'd like to contribute some more when I have time 🙃)

Basically just commented on style nitpicks so feel free to get a second opinion on some of these, but I tried to suggest a few things that might make the code a little more idiomatic.

Copy link
Member

@bryphe bryphe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor feedback on the names in the SyntaxHighlight module - but otherwise looks great!

@github-actions
Copy link

github-actions bot commented Jun 5, 2020

I have updated your lock dirs and formatted the code.
Please @zbaylin pull the last commit before pushing any more changes.

@zbaylin zbaylin merged commit a014b84 into master Jun 5, 2020
@Et7f3 Et7f3 deleted the feat/components/markdown branch June 5, 2020 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-components Area: Consumer-exposed components providing some convenience over the primitives enhancement New feature or request WIP
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants