[feat] Response body stored (only for JSON responses) #100

blackadress · 2022-01-29T16:27:05Z

#9 partially solves this as it can only store JSON responses.

For JSON parsing I'm using the decoding part of this library https://github.com/rxi/json.lua adding it to the plugin

NTBBloodbath · 2022-01-31T02:02:28Z

Hi, thanks for your interest in the project :)

Just a small question before merging, why use that json library instead of the built-in vim.json that is included in Neovim 0.6 onwards?

blackadress · 2022-01-31T18:54:58Z

why use that json library instead of the built-in vim.json that is included in Neovim 0.6 onwards?

Because I didn't know it existed o.O

I'll check vim.json and refactor accordingly

NTBBloodbath · 2022-02-01T17:30:32Z

Sweet, thank you!

It seems that our linter is raising some errors, can you please check our linter CI results and fix offenses if they're caused by this PR? Otherwise just let me know if they come from existing code in the repository and I'll fix them myself :)

Cheers

blackadress · 2022-02-03T02:23:21Z

The linter doesn't like global lua variables, so I replaced it with neovim's global variables 😅, maybe there is a better way to initialize the variable? I just initialized it on rest-nvim/init.lua

vim.api.nvim_set_var("req_var_store", { __loaded = true })

When I tried to initialize it on rest-nvim.vim, just got all kind of weird unexpected behavior 🤔

blackadress · 2022-02-17T17:28:56Z

@NTBBloodbath is there something else needed to merge this?

guruor · 2022-07-05T05:18:42Z

Any update on this?

blackadress · 2022-08-17T19:04:38Z

there is still a bug in there,
No such variable: "b:current_syntax"

This only happens from the second request onwards. and it happens here:

    local syntax_file = vim.fn.expand(string.format("$VIMRUNTIME/syntax/%s.vim", content_type))

    if vim.fn.filereadable(syntax_file) == 1 then
      vim.cmd(string.gsub(
        [[
        unlet b:current_syntax
        syn include @%s syntax/%s.vim
        syn region %sBody matchgroup=Comment start=+\v^#\+RESPONSE$+ end=+\v^#\+END$+ contains=@%s

        let b:current_syntax = "httpResult"
      ]],
        "%%s",
        content_type
      ))
    end

It confuses me, apparently the first time it gets the syntax_file it succeeds but then somehow it doesn't, any insights will be greatly appreciated.

NTBBloodbath · 2022-08-18T07:35:55Z

Ah, can you pull upstream main branch changes in the PR? I did submit a fix for this that day and sorry for the inconveniences!

blackadress · 2022-08-18T14:33:55Z

Done, haha I thought it was already synced

MikaelElkiaer · 2022-09-02T07:10:21Z

Trying this out right now. It is an awesome improvement!

I am utilizing this for a set-up like so:

keycloakHost: "http://localhost:8080"
keycloakRealm: "/realms/test"
clientId: "test"
accessToken: {{response.access_token}}

# well-known
GET {{keycloakRealm}}/.well-known/openid-configuration
Host: {{keycloakHost}}

# refresh token found in .env
#@response
POST {{keycloakRealm}}/protocol/openid-connect/token
Host: {{keycloakHost}}
Content-Type: application/x-www-form-urlencoded

grant_type=refresh_token
&client_id={{clientId}}
&refresh_token={{OAT_REFRESH_TOKEN}}

# route that requires a token
GET /api/test/auth
Host: http://localhost:8081
Authorization: Bearer {{accessToken}}

guruor · 2022-09-05T04:48:00Z

This is much needed feature, thanks for adding it.
During my testing I found few issues with variable naming convention. Not sure if they are documented somewhere.

Check last two cases here:

page: {{api_response.page}}
pageNo: {{api_response.page}}
page-number: {{api_response.page}}
page_number: {{api_response.page}}
url: {{api_response.support.url}}

# normal var
foo: 4

#@api_response
GET https://reqres.in/api/users?page=5

GET https://reqres.in/api/users?page={{foo}}

GET https://reqres.in/api/users?page={{page}}

GET {{url}}

# Works with variable `pageNo`
GET https://reqres.in/api/users?page={{pageNo}}

# Doesn't work with variable `page-number`, replaces the value as page=%7B%7Bpage-number%7D%7D
GET https://reqres.in/api/users?page={{page-number}}

# Doesn't work with variable `page_number`, this error is produced [bad argument #2 to 'gsub' (string/function/table expected)]
GET https://reqres.in/api/users?page={{page_number}}

guruor · 2022-09-05T05:00:12Z

One more thing I observed is that to access a stored variable in multiple http files, we need an explicit declaration in each http file, can this be moved to .env file.

Consider the snippet posted in this comment #100 (comment) as test1.http

test2.http

page: {{api_response.page}}

GET https://reqres.in/api/users?page={{page}}

GET https://reqres.in/api/users?page={{pageNo}}

Here, we are trying to reuse variables declared in test1.http in test2.http.
Variable page is accessible in test2.http because we redeclared it while pageNo is not accessible.

This can be a separate feature request, but posting it here since it is related and this feature is not yet merged.

MikaelElkiaer · 2022-09-05T06:14:54Z

I agree with @G0V1NDS. Related to his suggestion about using .env, I'd also add that it would be really useful to be able to set an initial value. E.g. page: {{response.page}} "0".

blackadress · 2022-09-06T01:07:22Z

Welp, this is an issue #100 (comment) however I'm thinking this is not due to this PR, probably has to do with the way the plugin parses the variable names (I'm thinking this because the string 'api_response' is a valid variable that stores the json response and is properly stored)

As for being able to reuse variables declared in different http files the most sensible way of doing it would be as suggested in a '.env' separated from the files (currently the req_var aka the variable that stores the json response e.g. '#@api_response' is a global for the plugin but the other variables e.g. 'page:' are local to the file.

The other suggestion to have an initial value for variables sounds really useful but probably should be on its own issue. On this I would like the syntax page: {{response.page}} or 0

The suggestions sound cool but I'm quite busy this month so I'll get back on October, I still suggest to make an issue for each of the suggestions. As for the bug, I think it is from the main branch can you look into it @G0V1NDS, I think I may be able to look into it this weekend.

MikaelElkiaer · 2022-10-20T10:40:48Z

~~Will this be going into main soon?~~

Never mind, just now noticed the stickied issue.

MikaelElkiaer · 2022-12-08T13:30:58Z

I am having some trouble with deconstructing arrays, and looking through the PR changes it does not seem to be handled.
Am I correct in this?

I assumed/hoped that I could do one of these:

a: {{response.array.0.prop}}
b: {{response.array[0].prop}}

guruor · 2023-02-22T06:44:51Z

@blackadress I observed another issue today, not sure if it is related to your change.

float_value: {{api_response.var_name}}

If the value of var_name is of type float then it is not parsed.
If we use float_value in following APIs {{float_value}} is sent in the payload.

guruor · 2023-02-26T16:47:37Z

Never mind, I was using the forked version, just tried the latest changes from official repo, it now has script-variables which works well for same use case. It doesn't have issue with float value for variables.

Though I started learning Neovim plugin development, will debug the variable parsing issue and will add tests for it.

blackadress · 2023-04-20T14:13:52Z

Now it is possible to deconstruct arrays with this syntax:

{{response.array.0.prop}}

I'm a little bit torn on the syntax as I think using '[0]' would have been best, but '.0' was easier to implement

teto · 2023-06-06T11:23:48Z

lua/rest-nvim/utils/init.lua

+-- if so, then replace {{bar}} or {{bar.baz}} with the proper value else return the same string
+-- only works if `bar` is a key in req_var_store
+-- @param value_str the value to evaluate
+M.replace_req_varibles = function(value_str)


lacks a a

teto · 2023-07-11T12:00:48Z

lua/rest-nvim/request/init.lua

@@ -240,8 +252,8 @@ local function end_request(bufnr, linenumber)
  end
  utils.move_cursor(bufnr, linenumber)

-  local next = vim.fn.search("^GET\\|^POST\\|^PUT\\|^PATCH\\|^DELETE\\|^###\\", "cn",
-    vim.fn.line("$"))
+  local next =


is this due to the formatter ?

teto · 2023-07-11T12:02:58Z

same as #207 (comment) I think this should/could be implemented as a callback.
What is req_var_store and why do we need it ?

teto · 2023-07-11T18:54:48Z

do you think you could achieve something similar via #214 (it's ok to patch rest.nvim if it doesn't send enough information) ?

blackadress · 2023-07-17T02:06:41Z

'req_var_store' is the variable in which I store the JSON variables e.g:

#@response
GET https://reqres.in/api/users?page=2

When executing this, the response is loaded in req_var_store like so:

req_var_store = { response = { ... full response ... } }

The other functionality is to check if it's loaded to validate on any try to get a key on req_var_store (now that I'm looking at it, this may be overkill)

Now about callbacks, I don't understand what you are saying, from #214 I get that you implemented callbacks to notify of the request being sent and finishing so wouldn't it just work? or do you want for this functionality to throw event when:

Starting the search to see if there is a valid JSON stored.
Ending the search with a valid/invalid response.
Loading a new variable to memory.

As I said I'm not following, I'd appreciate clarification.

…d' into response_body_stored

blackadress added 4 commits January 29, 2022 09:52

added json parser, and req variable parser

68b5ecf

allow for request variables on file

b9b6dd9

format and some light refactoring

3e7e2a2

basic usage example, and removed dev stuff

7c3e92b

deleted json library, using vim.json instead

9204928

removed lua global variable

e935082

NTBBloodbath and others added 3 commits August 9, 2022 03:36

Merge branch 'main' into response_body_stored

615c997

chore: updated variables to new changes from main

8319426

chore: debugger print deleted

bb9ada0

Merge branch 'rest-nvim:main' into response_body_stored

455d813

NTBBloodbath approved these changes Sep 2, 2022

View reviewed changes

Merge branch 'main' into response_body_stored

ffcb016

blackadress added 2 commits April 20, 2023 09:01

added support for accesing elements in array

db64cd6

sync repo

20aa804

blackadress added 2 commits May 9, 2023 12:28

Merge branch 'main' into response_body_stored

966b855

Merge branch 'main' into response_body_stored

7bdc941

teto reviewed Jun 6, 2023

View reviewed changes

teto reviewed Jul 11, 2023

View reviewed changes

blackadress added 2 commits July 17, 2023 14:53

Sync to main

92b80bc

Merge remote-tracking branch 'refs/remotes/origin/response_body_store…

d8e3339

…d' into response_body_stored

NTBBloodbath force-pushed the main branch from 244ac4d to f3d319f Compare February 12, 2024 12:47

boltlessengineer self-requested a review as a code owner December 28, 2024 19:06

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[feat] Response body stored (only for JSON responses) #100

[feat] Response body stored (only for JSON responses) #100

blackadress commented Jan 29, 2022

NTBBloodbath commented Jan 31, 2022

blackadress commented Jan 31, 2022

NTBBloodbath commented Feb 1, 2022

blackadress commented Feb 3, 2022

blackadress commented Feb 17, 2022

guruor commented Jul 5, 2022

blackadress commented Aug 17, 2022

NTBBloodbath commented Aug 18, 2022 •

edited

Loading

blackadress commented Aug 18, 2022

MikaelElkiaer commented Sep 2, 2022

guruor commented Sep 5, 2022

guruor commented Sep 5, 2022

MikaelElkiaer commented Sep 5, 2022

blackadress commented Sep 6, 2022

MikaelElkiaer commented Oct 20, 2022 •

edited

Loading

MikaelElkiaer commented Dec 8, 2022

guruor commented Feb 22, 2023

guruor commented Feb 26, 2023

blackadress commented Apr 20, 2023

teto Jun 6, 2023

teto Jul 11, 2023

blackadress Jul 17, 2023

teto commented Jul 11, 2023

teto commented Jul 11, 2023

blackadress commented Jul 17, 2023

[feat] Response body stored (only for JSON responses) #100

Are you sure you want to change the base?

[feat] Response body stored (only for JSON responses) #100

Conversation

blackadress commented Jan 29, 2022

NTBBloodbath commented Jan 31, 2022

blackadress commented Jan 31, 2022

NTBBloodbath commented Feb 1, 2022

blackadress commented Feb 3, 2022

blackadress commented Feb 17, 2022

guruor commented Jul 5, 2022

blackadress commented Aug 17, 2022

NTBBloodbath commented Aug 18, 2022 • edited Loading

blackadress commented Aug 18, 2022

MikaelElkiaer commented Sep 2, 2022

guruor commented Sep 5, 2022

guruor commented Sep 5, 2022

MikaelElkiaer commented Sep 5, 2022

blackadress commented Sep 6, 2022

MikaelElkiaer commented Oct 20, 2022 • edited Loading

MikaelElkiaer commented Dec 8, 2022

guruor commented Feb 22, 2023

guruor commented Feb 26, 2023

blackadress commented Apr 20, 2023

teto Jun 6, 2023

Choose a reason for hiding this comment

teto Jul 11, 2023

Choose a reason for hiding this comment

blackadress Jul 17, 2023

Choose a reason for hiding this comment

teto commented Jul 11, 2023

teto commented Jul 11, 2023

blackadress commented Jul 17, 2023

NTBBloodbath commented Aug 18, 2022 •

edited

Loading

MikaelElkiaer commented Oct 20, 2022 •

edited

Loading