Copy options before adding callback.

request · Feb 6, 2013 · e4d1e25 · e4d1e25
1 parent 28e8be5
commit e4d1e25
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/main.js b/main.js
@@ -105,7 +105,6 @@ function Request (options) {
       }
     }
   }
-  options = copy(options)
 
   this.init(options)
 }
@@ -1095,6 +1094,8 @@ function request (uri, options, callback) {
     options = uri
   }
 
+  options = copy(options)
+
   if (callback) options.callback = callback
   var r = new Request(options)
   return r

diff --git a/tests/test-params.js b/tests/test-params.js
@@ -82,7 +82,8 @@ s.listen(s.port, function () {
         }
         counter = counter - 1;
         if (counter === 0) {
-          console.log(Object.keys(tests).length+" tests passed.")
+          assert.notEqual(typeof test.callback, 'function')
+          console.log(1 + Object.keys(tests).length+" tests passed.")
           s.close()
         }
       })