Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: timingRecord for siwe email spec beforeAll #4099

Merged
merged 4 commits into from
Mar 31, 2025

Conversation

chris13524
Copy link
Member

@chris13524 chris13524 commented Mar 27, 2025

Description

Slack conversation

Type of change

  • Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Associated Issues

For Linear issues: Closes APKT-xxx
For GH issues: closes #...

Showcase (Optional)

If there is a UI change include the screenshots with before and after state.
If new feature is being introduced, include the link to demo recording.

Checklist

  • Code in this PR is covered by automated tests (Unit tests, E2E tests)
  • My changes generate no new warnings
  • I have reviewed my own code
  • I have filled out all required sections
  • I have tested my changes on the preview link
  • Approver of this PR confirms that the changes are tested on the preview link

@chris13524 chris13524 requested a review from tomiir March 27, 2025 17:51
@chris13524 chris13524 self-assigned this Mar 27, 2025
Copy link

changeset-bot bot commented Mar 27, 2025

⚠️ No Changeset found

Latest commit: 4b6d307

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Mar 27, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
appkit-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 31, 2025 3:49pm
appkit-laboratory ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 31, 2025 3:49pm
12 Skipped Deployments
Name Status Preview Comments Updated (UTC)
appkit-basic-ep ⬜️ Ignored (Inspect) Mar 31, 2025 3:49pm
appkit-basic-ep-example ⬜️ Ignored (Inspect) Mar 31, 2025 3:49pm
appkit-basic-example ⬜️ Ignored (Inspect) Mar 31, 2025 3:49pm
appkit-basic-sign-client-example ⬜️ Ignored (Inspect) Mar 31, 2025 3:49pm
appkit-basic-up-example ⬜️ Ignored (Inspect) Mar 31, 2025 3:49pm
appkit-ethers5-bera ⬜️ Ignored (Inspect) Mar 31, 2025 3:49pm
appkit-nansen-demo ⬜️ Ignored (Inspect) Mar 31, 2025 3:49pm
appkit-vue-solana ⬜️ Ignored (Inspect) Mar 31, 2025 3:49pm
appkit-wagmi-cdn-example ⬜️ Ignored (Inspect) Mar 31, 2025 3:49pm
ethereum-provider-wagmi-example ⬜️ Ignored (Inspect) Visit Preview Mar 31, 2025 3:49pm
next-wagmi-solana-bitcoin-example ⬜️ Ignored (Inspect) Mar 31, 2025 3:49pm
vue-wagmi-example ⬜️ Ignored (Inspect) Mar 31, 2025 3:49pm

Copy link
Contributor

github-actions bot commented Mar 27, 2025

Warnings
⚠️ File apps/laboratory/tests/siwe-email.spec.ts contains a KEY or SECRET

Generated by 🚫 dangerJS against 4b6d307

Copy link
Contributor

github-actions bot commented Mar 27, 2025

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 74.98% 24903 / 33212
🔵 Statements 74.98% 24903 / 33212
🔵 Functions 66.18% 2104 / 3179
🔵 Branches 83.04% 4770 / 5744
File CoverageNo changed files found.
Generated in workflow #10566 for commit 4b6d307 by the Vitest Coverage Report Action

@chris13524 chris13524 merged commit 35b8d25 into main Mar 31, 2025
31 checks passed
@chris13524 chris13524 deleted the chore/email-siwe-test-connect-timing branch March 31, 2025 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants