Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: form state dep array #4095

Merged
merged 3 commits into from
Mar 28, 2025
Merged

fix: form state dep array #4095

merged 3 commits into from
Mar 28, 2025

Conversation

devceline
Copy link
Contributor

@devceline devceline commented Mar 27, 2025

Description

  • Fix issue with form state not updating if updated out of order

Type of change

  • Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • Code in this PR is covered by automated tests (Unit tests, E2E tests)
  • My changes generate no new warnings
  • I have reviewed my own code
  • I have filled out all required sections
  • I have tested my changes on the preview link
  • Approver of this PR confirms that the changes are tested on the preview link

Copy link

changeset-bot bot commented Mar 27, 2025

⚠️ No Changeset found

Latest commit: decad34

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Mar 27, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
appkit-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 28, 2025 7:16am
appkit-laboratory ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 28, 2025 7:16am
12 Skipped Deployments
Name Status Preview Comments Updated (UTC)
appkit-basic-ep ⬜️ Ignored (Inspect) Mar 28, 2025 7:16am
appkit-basic-ep-example ⬜️ Ignored (Inspect) Mar 28, 2025 7:16am
appkit-basic-example ⬜️ Ignored (Inspect) Mar 28, 2025 7:16am
appkit-basic-sign-client-example ⬜️ Ignored (Inspect) Mar 28, 2025 7:16am
appkit-basic-up-example ⬜️ Ignored (Inspect) Mar 28, 2025 7:16am
appkit-ethers5-bera ⬜️ Ignored (Inspect) Mar 28, 2025 7:16am
appkit-nansen-demo ⬜️ Ignored (Inspect) Mar 28, 2025 7:16am
appkit-vue-solana ⬜️ Ignored (Inspect) Mar 28, 2025 7:16am
appkit-wagmi-cdn-example ⬜️ Ignored (Inspect) Mar 28, 2025 7:16am
ethereum-provider-wagmi-example ⬜️ Ignored (Inspect) Visit Preview Mar 28, 2025 7:16am
next-wagmi-solana-bitcoin-example ⬜️ Ignored (Inspect) Mar 28, 2025 7:16am
vue-wagmi-example ⬜️ Ignored (Inspect) Mar 28, 2025 7:16am

Copy link
Contributor

github-actions bot commented Mar 27, 2025

Warnings
⚠️ File apps/laboratory/src/components/Wagmi/WagmiSendCallsCustomAbiWithPaymasterServiceTest.tsx contains a KEY or SECRET

Generated by 🚫 dangerJS against decad34

Copy link
Contributor

github-actions bot commented Mar 27, 2025

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 75.11% 24757 / 32957
🔵 Statements 75.11% 24757 / 32957
🔵 Functions 66.33% 2093 / 3155
🔵 Branches 82.77% 4701 / 5679
File CoverageNo changed files found.
Generated in workflow #10514 for commit decad34 by the Vitest Coverage Report Action

Copy link
Collaborator

@Cali93 Cali93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also add links to docs/instructions in this PR?

@arein arein enabled auto-merge (squash) March 28, 2025 07:11
@arein arein merged commit d057114 into main Mar 28, 2025
31 checks passed
@arein arein deleted the fix/form-state-custom-abi branch March 28, 2025 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants