You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds TelemetryController to report errors to our Pulse API
Adds AppKitError abstraction to handle all of AppKit's potential erros. So far API_ERROR and INTERNAL_SDK_ERROR are used but types also contemplate secure site errors (coming next on secure site)
Adds withErrorBoundary util for controllers that intercepts requests and if they have uncaught errrors, fires a request to TelemetryController
WIP: Adds abstraction on top of AK's clients to catch uncaught errors and forward to telemetry
Type of change
Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Associated Issues
Closes APKT-2409
Checklist
Code in this PR is covered by automated tests (Unit tests, E2E tests)
My changes generate no new warnings
I have reviewed my own code
I have filled out all required sections
I have tested my changes on the preview link
Approver of this PR confirms that the changes are tested on the preview link
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
TelemetryController
to report errors to our Pulse APIAppKitError
abstraction to handle all of AppKit's potential erros. So farAPI_ERROR
andINTERNAL_SDK_ERROR
are used but types also contemplate secure site errors (coming next on secure site)withErrorBoundary
util for controllers that intercepts requests and if they have uncaught errrors, fires a request toTelemetryController
Type of change
Associated Issues
Closes APKT-2409
Checklist