Merge pull request #22 from rwjblue/dry-run-does-not-launch-editor

Ensure `--dry-run` does not launch editor.
release-it-plugins · Mar 27, 2020 · ae871bd · ae871bd
2 parents 4ee1ab8 + 0ca7a91
commit ae871bd
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 0 deletions.
diff --git a/index.js b/index.js
@@ -69,6 +69,11 @@ module.exports = class LernaChangelogGeneratorPlugin extends Plugin {
   }
 
   async _launchEditor(tmpFile) {
+    // do not launch the editor for dry runs
+    if (this.global.isDryRun) {
+      return;
+    }
+
     let editorCommand;
 
     if (typeof this.options.launchEditor === 'boolean') {

diff --git a/test.js b/test.js
@@ -186,6 +186,20 @@ test('uses launchEditor command', async t => {
   t.is(fs.readFileSync(output, 'utf-8'), `args: ${plugin.launchedTmpFile}`);
 });
 
+test('does not launch the editor for dry-run', async t => {
+  let infile = tmp.fileSync().name;
+
+  let { editor, output } = await buildEditorCommand();
+
+  let plugin = buildPlugin({ infile, launchEditor: `${editor} \${file}` });
+
+  plugin.global.isDryRun = true;
+
+  await runTasks(plugin);
+
+  t.is(fs.readFileSync(output, 'utf-8'), ``);
+});
+
 test('detects default editor if launchEditor is `true`', async t => {
   let infile = tmp.fileSync().name;