-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FEATURE: added a datepicker module(#237) #240
Conversation
Thanks for taking this on! A couple things the library seems to be As for props and events More props can be these but snake case: closeOnScroll, dateFormat, startDate, endDate, minDate, maxDate, isClearable, placeholderText, showWeekNumbers, shouldCloseOnSelect |
fixed name of package added names to init
8f50513
to
92bacab
Compare
I have added the new props. However, should the date values be of I ahve not tested locally. I am working in a Codespace. The tests are running fine. |
Looking good thanks for the changes, can you add comment and doc strings like our other components also can you text to see if it runs locally. https://github.com/pynecone-io/pynecone/blob/main/pynecone/components/datadisplay/datatable.py |
I have added the docstring. I am trying to test locally but I getting a here is my code. class DatePickerState(pc.State):
date = "1/1/2001"
def index():
return pc.center(
pc.vstack(
pc.heading(DatePickerState.date),
date_picker(on_change=DatePickerState.set_date),
pc.box("Get started by editing ",
pc.code(filename, font_size="1em")),
pc.link(
"Check out our docs!",
href=docs_url,
border="0.1em solid",
padding="0.5em",
border_radius="0.5em",
_hover={
"color": "rgb(107,99,246)",
},
),
spacing="1.5em",
font_size="2em",
),
padding_top="10%",
)
# Add state and page to the app.
app = pc.App(state=State)
app.add_page(index)
app.compile() |
It looks like you're passing the wrong State class to your app. You probably want to do
Or if you meant to use substates, you need to make sure your new class subclasses your base state rather than
|
Going to close this pr seems inactive. |
Adds #237
Right now it only had the
value
prop, but I will add more as per comments.