Allow customization of ProgressHUD through ProgressHUDAppearance #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cheesebaron
force-pushed
the
bugfix/gh106-customization
branch
from
be74891 to
21fdab8
Compare
Closed
Cheesebaron
force-pushed
the
bugfix/gh106-customization
branch
from
07ff175 to
f35db92
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ What kind of change does this PR introduce? (Bug fix, feature, docs update...)
Customization of ProgressHUD has to happen through specific instances of the HUD, rather than the static
BTProgressHUDclass as before.🆕 What is the new behavior (if this is a feature change)?
Added a
ProgressHUDAppearanceclass where all customization of, images, fonts, sizes and colors can be made.Removed some old code that checks for versioning and automatically applies system appearance, this is now controllable and overridable through the appearance class.
💥 Does this PR introduce a breaking change?
Shouldn't™️
🐛 Recommendations for testing
Run the sample app and check the various huds
📝 Links to relevant issues/docs
Fixes #106
🤔 Checklist before submitting