Skip to content

Commit

Permalink
Add missing check_health argument to Connection overrides (#1323)
Browse files Browse the repository at this point in the history
Now matches the parent class signature. Running the benchmark previously
failed with the error:

    TypeError: send_packed_command() got an unexpected keyword argument 'check_health'
  • Loading branch information
jdufresne authored Apr 11, 2020
1 parent 98242bb commit 2fcd547
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions benchmarks/command_packer_benchmark.py
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@


class StringJoiningConnection(Connection):
def send_packed_command(self, command):
def send_packed_command(self, command, check_health=True):
"Send an already packed command to the Redis server"
if not self._sock:
self.connect()
Expand Down Expand Up @@ -38,7 +38,7 @@ def pack_command(self, *args):


class ListJoiningConnection(Connection):
def send_packed_command(self, command):
def send_packed_command(self, command, check_health=True):
if not self._sock:
self.connect()
try:
Expand Down

0 comments on commit 2fcd547

Please sign in to comment.