-
Notifications
You must be signed in to change notification settings - Fork 607
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support *SCAN methods on async connections #326
Conversation
Oh, this doesn't work because the implementations of aio::ConnectionLike are calling |
OK fixed. It's a breaking change though because I had to change the signature of |
Finally, got the tests to pass. Man, it's crippling when you can't run them all. The only failure now is clippy saying that we should name the |
I'd rename it to I guess you could get tests working locally if you tweak the tests to read an environment variable which contains a custom command to run instead of redis and use that start redis in a docker instance, |
@@ -62,7 +62,7 @@ cluster = ["crc16", "rand"] | |||
script = ["sha1"] | |||
async-std-comp = ["aio", "async-std"] | |||
tokio-comp = ["aio", "tokio"] | |||
connection-manager = ["tokio-rt-core", "arc-swap", "futures"] | |||
connection-manager = ["futures", "tokio-rt-core", "arc-swap", "futures"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this duplicate value somehow necessary? Curious as I'm working on a merge into #319. I think this can be trimmed.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, that can probably be removed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, I've updated #319. Cheers.
Following the pattern set by Iter, I implemented an AsyncIter and exposed it up through AsyncCommands. Thanks to @Marwes who helped me a lot.
Unfortunately I'm on Windows, so I don't have redis-server installed and I can't run the tests myself. I usually use Docker to run redis.