Fix extensions printing #2674
Merged
Fix extensions printing #2674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anmonteiro
reviewed
Oct 29, 2022
…extensions * 'fix-extensions' of github.com:/davesnx/reason: Prepare for 3.8.2 (reasonml#2673)
davesnx
force-pushed
the
fix-extensions
branch
from
3debf7d to
b4a3d03
Compare
davesnx
force-pushed
the
fix-extensions
branch
from
f05b649 to
cf9ce95
Compare
This was referenced Nov 12, 2022
anmonteiro
reviewed
Nov 20, 2022
| @@ -237,7 +237,10 @@ class boxB ('a) (init: 'a) = | |||
|
|
|||
| /* To be able to put an attribute on just the return in that case, use | |||
| * parens. */ | |||
| [@onBoxC x; y] | |||
| [@onBoxC | |||
There was a problem hiding this comment.
this one is a little awkward
There was a problem hiding this comment.
At first, I found it weird but later made sense. Any structure_item inside an attribute should be treated like a structure_item without an attribute...
I can roll it back thought.
There was a problem hiding this comment.
that does make sense. happy to keep it as is
anmonteiro
reviewed
Nov 20, 2022
| [@someattr] | ||
| let foo: int => int; | ||
| }; | ||
| module Foo: {[@someattr] |
anmonteiro
reviewed
Nov 20, 2022
anmonteiro
reviewed
Nov 20, 2022
anmonteiro
approved these changes
Nov 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When printing code with refmt: Extensions are printed with and without brackets
[]in some cases, creating a few problems:This PR tries to unify them to always add
[]while respecting the inline let attributes added #1703.