Fix braces removal in JSX props when having a pipe-first call contain…

…ing a callback (#2474) * Fix braces removal in JSX props when having a pipe-first call containing a callback Made with the precious help from @anmonteiro Closes #2471 * Add a test with another case where braces were removed
reasonml · Oct 29, 2019 · a8f7d90 · a8f7d90
1 parent e8d33b8
commit a8f7d90
Show file tree

Hide file tree

Showing 3 changed files with 32 additions and 1 deletion.
diff --git a/formatTest/unit_tests/expected_output/jsx.re b/formatTest/unit_tests/expected_output/jsx.re
@@ -658,3 +658,22 @@ let v =
       }}
     </B>
   </A>;
+
+<Component
+  prop={
+    x->Option.map(x => {
+      let y = x;
+      y ++ y;
+    })
+  }
+/>;
+
+<Component
+  prop={
+    name:
+      x->Option.map(x => {
+        let y = x;
+        y ++ y;
+      }),
+  }
+/>;
diff --git a/formatTest/unit_tests/input/jsx.re b/formatTest/unit_tests/input/jsx.re
@@ -532,3 +532,15 @@ let v =
       }}
     </B>
   </A>;
+
+<Component
+  prop={
+    x->Option.map(x => {let y = x; y ++ y})
+  }
+/>;
+
+<Component
+  prop={{
+    name: x->Option.map(x => {let y = x; y ++ y})
+  }}
+/>;
diff --git a/src/reason-parser/reason_pprint_ast.ml b/src/reason-parser/reason_pprint_ast.ml
@@ -3753,7 +3753,7 @@ let printer = object(self:'self)
               {exp with pexp_loc = { exp.pexp_loc with loc_end = loc_end } }
             in
             makeList (
-              self#formatFunAppl
+              self#reset_request_braces#formatFunAppl
                 ?prefix
                 ~jsxAttrs:[]
                 ~args