-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pointed users to Python3.6 #3817
Conversation
Hi @varunotelli I see you made 3 PRs for the same issue, you don't need do to that, you can push to the same branch and GitHub will update the PR. Let me know if you need more help. |
@stsewd this is my first time contributing so i didn't clone the repo and just edited the doc online. Sorry about that. |
@varunotelli you can check this #3766 (comment) for learning more about git and GitHub |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, thanks for your contrubution! The changes look great 👍 to me.
Linting errors are unrelated and fixed in master. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@varunotelli could you also update your branch? I think it's now possible to do it via GitHub UI. It should show a button like "sync your branch" or "update your branch" (I don't remember the exact wording)
virtual environment will make the installation easier, and will help to avoid | ||
clutter in your system-wide libraries. You will also need Git_ in order to | ||
clone the repository. If you plan to import Python 3 project to your RTD then you'll | ||
need to install Python 3 with virtualenv in your system as well. | ||
clone the repository. If you plan to import Python 2.7 project to your RTD then you'll |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can just drop this sentence. Python 2 will stay installed on most systems if I remember correctly. There is a proposal to link python
to python3
or python3.X
on some systems, but I doubt that will be accepted by Guido or other Python core developers.
@humitos Done |
Thanks for this PR! |
Removed the warning and pointed users to python3.6 as suggested in PR #3814