Pin astroid to fix linter issue on travis #3816
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Related PR where this is exposed #3813 |
humitos
reviewed
Mar 16, 2018
There was a problem hiding this comment.
Thanks to fix this!
astroid==1.6.2 was released today and if this contains that bug, that's why it started to happen.
I suggest you to add a comment before the pinned package about why this is happening and a link to the issue also. This is useful later when we want to upgrade, we will know what was happening and can be sure that it's already fixed.
agjohnson
approved these changes
Mar 20, 2018
|
pylint-dev/pylint-django#117 was closed today (pylint-dev/pylint-django@abd1164). So in some days/weeks? we can try to unpin/update astroid. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this is a bug on pylint-django pylint-dev/pylint-django#117 (comment)
I tried with
pylint==1.8.2but didn't solve the problem.