Skip to content

Commit

Permalink
Allow some specific exceptions
Browse files Browse the repository at this point in the history
  • Loading branch information
humitos committed Dec 16, 2017
1 parent 5b240bc commit 5630fad
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 5 deletions.
3 changes: 1 addition & 2 deletions readthedocs/core/utils/extend.py
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,7 @@ def get_override_class(proxy_class, default_class=None):

class SettingsOverrideMeta(type):

"""Meta class for passing along classmethod class to the underlying
class."""
"""Meta class for passing along classmethod class to the underlying class.""" # noqa

def __getattr__(cls, attr): # noqa: pep8 false positive
proxy_class = get_override_class(cls, getattr(cls, '_default_class'))
Expand Down
3 changes: 1 addition & 2 deletions readthedocs/doc_builder/environments.py
Original file line number Diff line number Diff line change
Expand Up @@ -391,8 +391,7 @@ def run_command_class(self, cls, cmd, **kwargs):

@property
def successful(self):
"""Is build completed, without top level failures or failing
commands."""
"""Is build completed, without top level failures or failing commands.""" # noqa
return (self.done and self.failure is None and
all(cmd.successful for cmd in self.commands))

Expand Down
2 changes: 1 addition & 1 deletion readthedocs/restapi/views/model_views.py
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@ def canonical_url(self, request, **kwargs):
})

@decorators.detail_route(permission_classes=[permissions.IsAdminUser], methods=['post'])
def sync_versions(self, request, **kwargs):
def sync_versions(self, request, **kwargs): # noqa: D205
"""
Sync the version data in the repo (on the build server) with what we
have in the database.
Expand Down

0 comments on commit 5630fad

Please sign in to comment.