feat: add Windows New Arch Support #278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ipboard into windows-new-arch
|
@Naturalclar I have opened this to replace #274 without the last 0.76 commit. Let me know if this needs anything else. |
Rexogamer
reviewed
Jan 13, 2025
Comment on lines
+46
to
+49
| "dependencies": { | ||
| "react-native": "^0.75.3", | ||
| "react-native-windows": "^0.75.0" | ||
| }, |
There was a problem hiding this comment.
this introduces a dependency on these for apps that install the latest version of RNClipboard, leading to duplicate versions of RN. was there any reason to move these to direct dependencies?
There was a problem hiding this comment.
@Naturalclar thank you for tackling the issue!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-creating #274
Overview
Add support for the New Architecture on Windows.
Test Plan
Run the following in a command line tool at the
clipboardroot:Screenshots of Example app on both Old and New Architecture:
Old Arch:
New Arch:
Note: hitting some intermittent hoisting issues with the example app, where duplicate copies of certain packages are being created in both
~/package.jsonand~/example/package.json, causing build issues for the example app.