perf: selectively perform matches

[jeswr]

Summary by CodeRabbit

• New Features

  • Improved matching logic for processing graphs in the N3 store, enhancing clarity and control flow.

• Bug Fixes

  • Enhanced test coverage for the match method, ensuring accurate validation across various scenarios.

• Tests

  • Added new assertions and structured test cases for comprehensive validation of matching functionality.

[coderabbitai]

Warning

Rate limit exceeded

@github-actions[bot] has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 23 minutes and 45 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Files that changed from the base of the PR and between be8a7ad and e93e562.

Walkthrough

The changes involve restructuring the matching logic within the DatasetCoreAndReadableStream class in src/N3Store.js to enhance clarity and control flow. Additionally, the test cases in test/N3Store-test.js have been expanded to cover various scenarios for the match method, improving the validation of its functionality.

Changes

File	Change Summary
src/N3Store.js	Modified the matching logic in the DatasetCoreAndReadableStream class to separate conditions for subjects, predicates, and objects. Improved control flow and organization of the matching process.
test/N3Store-test.js	Enhanced test cases for the Store functionality, including new assertions and a structure for comprehensive matching tests. Added variable quad in DataFactory.

Possibly related PRs

• perf: perform matching over indices #443: The changes in this PR modify the DatasetCoreAndReadableStream class to incorporate a new indexMatch function, which enhances the matching logic similar to the restructuring of the matching process in the main PR.

Suggested labels

released

Suggested reviewers

• RubenVerborgh

🐇 In the code where the graphs play,
A new match logic found its way.
With tests that cover every case,
Our store now runs with better grace.
Hooray for changes, clear and bright,
Let’s hop along, all feels just right! 🐇

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 2

🧹 Outside diff range and nitpick comments (2)

test/N3Store-test.js (2)

17-17: Unnecessary import: 'quad' is not used

The quad function imported from DataFactory is not utilized in the code. Removing unused imports helps keep the code clean.

Apply this diff to remove the unused import:

-const { namedNode, quad } = DataFactory;
+const { namedNode } = DataFactory;

---

2003-2003: Typographical error in test description

There's a minor typo in the test description. It should use 'a' instead of 'an' before 'range'.

Apply this diff to correct the typo:

-'perform matches on an range of defined and undefined elements',
+'perform matches on a range of defined and undefined elements',

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 373e90e and be8a7ad.

📒 Files selected for processing (2)

• src/N3Store.js (1 hunks)
• test/N3Store-test.js (2 hunks)

[github-actions]

🎉 This PR is included in version 1.22.3 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀