Use nvcomp wheel instead of bundling nvcomp #16946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KyleFromNVIDIA
added
improvement
github-actions
bot
added
libcudf
jameslamb
reviewed
Sep 30, 2024
bdice
reviewed
Sep 30, 2024
|
@bdice I've applied your suggestions to rapidsai/kvikio#478 too. |
bdice
reviewed
Oct 1, 2024
robertmaynard
approved these changes
Oct 1, 2024
bdice
approved these changes
Oct 1, 2024
vyasr
approved these changes
Oct 1, 2024
|
/merge |
|
Note that this has broken downstream projects that build from a libcudf installed area since nvcomp is no longer installed alongside libcudf artifacts. See #16986. |
rapids-bot bot
pushed a commit
that referenced
this pull request
Nov 8, 2024
Related to rapidsai/build-planning#33 and rapidsai/build-planning#74 The last use of CMake function `install_aliased_imported_targets()` here was removed in #16946. This proposes removing the file holding its definition. Authors: - James Lamb (https://github.com/jameslamb) Approvers: - Kyle Edwards (https://github.com/KyleFromNVIDIA) URL: #17276
3 tasks
rapids-bot bot
pushed a commit
that referenced
this pull request
Jan 23, 2025
Follow-up to #16946 Adds a matrix filter `use_cuda_wheels` in the `dependencies.yaml` list used for `libcudf`'s `nvcomp` dependency. Some types of builds (like RAPIDS devcontainers) prefer to use the system-installed nvCOMP to one provided by wheels. This ensures that preference is respected, because those builds pass matrix selector `use_cuda_wheels=false` through `rapids-dependency-file-generator` (rapidsai/devcontainers#382). ## Notes for Reviewers ### How I tested this Saw that `nvidia-nvcomp-cu12` made it into the environment in pip devcontainers builds in previous PRs: ```text ... numpy>=1.23,<3.0a0 nvidia-nvcomp-cu12==4.1.0.6 nvtx>=0.2.1 ... ``` ([logs from recent PR build in this repo](https://github.com/rapidsai/cudf/actions/runs/12860325999/job/35852085397#step:8:1010)) It's not there as of this PR 😁 ```text ... numpy>=1.23,<3.0a0 nvtx>=0.2.1 ... ``` ([build link](https://github.com/rapidsai/cudf/actions/runs/12896597574/job/35959950655?pr=17774#step:8:1028)) # Authors: - James Lamb (https://github.com/jameslamb) - Bradley Dice (https://github.com/bdice) Approvers: - Bradley Dice (https://github.com/bdice) URL: #17774
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Contributes to https://github.com/rapidsai/rapids-wheels-planning/issues/74
Checklist