Fix CI - adds Ruby 3.4 and Rails 8 #210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trevorrjohn
force-pushed
the
fix-test
branch
8 times, most recently
from
f97228a to
04f4f37
Compare
trevorrjohn
force-pushed
the
fix-test
branch
3 times, most recently
from
0bb5f54 to
8f1562e
Compare
trevorrjohn
force-pushed
the
fix-test
branch
3 times, most recently
from
84709f7 to
7d3f032
Compare
trevorrjohn
changed the title
trevorrjohn
changed the title
nvasilevski
reviewed
Jan 29, 2025
- pin concurrent-ruby because logger is not explicitly requried < 7.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates tests to handle Rails 8
Adds a CI variation for Ruby 3.4
And Rails 8
concurrent-ruby needs to be pinned to a lower version on older versions of Rails