Fix: literal-compare-order crash on BDD-style assertions (fixes #74)

qunitjs · May 12, 2020 · e055c1b · e055c1b
1 parent 5dec4fc
commit e055c1b
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/lib/utils.js b/lib/utils.js
@@ -62,6 +62,7 @@ const ASSERTION_METADATA = {
 function getAssertionMetadata(calleeNode, assertVar) {
     if (calleeNode.type === "MemberExpression") {
         return calleeNode.object &&
+            calleeNode.object.type === "Identifier" &&
             calleeNode.object.name === assertVar &&
             calleeNode.property &&
             Object.hasOwnProperty.call(ASSERTION_METADATA, calleeNode.property.name) &&

diff --git a/tests/lib/rules/literal-compare-order.js b/tests/lib/rules/literal-compare-order.js
@@ -74,7 +74,10 @@ ruleTester.run("literal-compare-order", rule, {
         wrap("notPropEqual(variable, 'Literal');"),
         wrap("notPropEqual(variable, 'Literal', 'Message');"),
         wrap("assert.notPropEqual(variable, 'Literal');"),
-        wrap("assert.notPropEqual(variable, 'Literal', 'Message');")
+        wrap("assert.notPropEqual(variable, 'Literal', 'Message');"),
+
+        // avoid crash in BDD-style assertions
+        "QUnit.test('Name', function() { expect(variable).to.equal('Literal'); });"
     ],
     invalid: [
         // equal