[INVALID] Custom mining with verification. #360
Conversation
| static constexpr unsigned long long _invalidTaskIndex = 0xFFFFFFFFFFFFFFFFULL; | ||
| void init() | ||
| { | ||
| allocatePool(CUSTOM_MINING_TASK_STORAGE_COUNT * sizeof(CustomMiningTask), (void**)&_customMiningTasks); |
There was a problem hiding this comment.
please use allocPoolWithErrorLog instead
| _customMiningPhaseCount = 1; | ||
| } | ||
|
|
||
| void checkAndReset() |
There was a problem hiding this comment.
please add a note here which process calling this
| } | ||
|
|
||
| // Binary search for taskIndex or closest greater-than task index | ||
| unsigned long long searchTaskIndex(unsigned long long taskIndex, bool& exactMatch) const |
There was a problem hiding this comment.
please add unit tests for this function, we usually have hang/bug on binary search function before
| static constexpr unsigned long long _invalidIndex = 0xFFFFFFFFFFFFFFFFULL; | ||
| void init() | ||
| { | ||
| allocatePool(maxItems * sizeof(DataType), (void**)&_data); |
There was a problem hiding this comment.
please use allocPoolWithErrorLog instead
| struct RespondCustomMiningTask | ||
| { | ||
| static constexpr int _maxNumberOfTasks = 4; | ||
| static constexpr int _maxNumberSolutions = 64; |
There was a problem hiding this comment.
any intention behind these numbers 4 and 64?
| @@ -2,7 +2,7 @@ | |||
|
|
|||
| #include <lib/platform_efi/uefi.h> | |||
|
|
|||
| static unsigned char consoleLoggingLevel = 1; | |||
| static unsigned char consoleLoggingLevel = 2; | |||
| @@ -4,7 +4,7 @@ | |||
|
|
|||
| // Do NOT share the data of "Private Settings" section with anybody!!! | |||
|
|
|||
| #define OPERATOR "AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA" | |||
| #define OPERATOR "YRZVDJHUSNYBQFIWUWCVSEQVBLWBIMNOUUVJKWXLSAAODNHMZYQASNWDMQNA" | |||
| const unsigned short computorID = request->nonce % NUMBER_OF_COMPUTORS; | ||
|
|
||
| ACQUIRE(gCustomMiningSharesCountLock); | ||
| gCustomMiningSharesCount[computorID]++; |
There was a problem hiding this comment.
If there is no verifier, the nodes consider all shares are valid by default. (need to re-think)
So when verifier tells node that nonce_X isn't valid, we do gCustomMiningSharesCount[nonce_X % 676]--. Otherwise, no action needed.
It would be nice to have a flag indicating if nonce_X is verified or not
cyber-pc
changed the title
This PR contains,