Properly Rename Extra CA Certificates (PROJQUAY-1306) #372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alecmerdler
changed the title
alecmerdler
force-pushed
the
PROJQUAY-1306
branch
3 times, most recently
from
72c19ed to
08d3ab4
Compare
alecmerdler
changed the title
alecmerdler
force-pushed
the
PROJQUAY-1306
branch
from
08d3ab4 to
05d19fe
Compare
… creating new 'configBundleSecret' for '/reconfigure' endpoint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: https://issues.redhat.com/browse/PROJQUAY-1306
Changelog: Only add
extra_ca_cert_prefix to actual extra CA certificates when creating newconfigBundleSecret.Docs: N/a
Testing: N/a
Details: We were previously adding the
extra_ca_cert_prefix to all certificates received by thecertspayload to the/reconfigureendpoint. This is incorrect, as some files are used for other purposes (likecloudfront-signing-key.pem) and are referenced by filename inconfig.yaml. Changing the name of this file breaks Quay when it tries to open the file.