Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Route TLS Fixes for Security Scanner (PROJQUAY-1091) #322

Merged
merged 1 commit into from
Sep 25, 2020

Conversation

alecmerdler
Copy link
Contributor

Issue: https://issues.redhat.com/browse/PROJQUAY-1091

Changelog: Switch to always passthrough TLS for Route and generate cert/key pair if not provided.

Docs: N/a

Testing: TODO(alecmerdler)

Details:

We cannot use edge TLS termination with OpenShift Routes because there is not an easy or reliable way of retrieving the cluster CA that is used by the Ingress Operator when it creates Routes. This is a problem because Clair needs to trust the HTTPS of whatever storage backend it is fetching image layers from. Instead, we switch to always terminating TLS at the Quay container (which is preferred anyway) and generating a cert/key pair if the user does not provide them in their configBundleSecret.

  • Remove edge TLS termination for Quay Route and only allow passthrough targeting the https port
  • Ensure FEATURE_PROXY_STORAGE is enabled and we are using s3.openshift-storage.svc and injecting service-ca.crt to Quay and config-tool Deployments
  • Generate ssl.key + ssl.cert if not provided

Reverts work done in: #320 and #315

@alecmerdler alecmerdler merged commit f0f8bd4 into quay:master Sep 25, 2020
@alecmerdler alecmerdler deleted the PROJQUAY-1107 branch September 25, 2020 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

1 participant