Route TLS Fixes for Security Scanner (PROJQUAY-1091) #322
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: https://issues.redhat.com/browse/PROJQUAY-1091
Changelog: Switch to always
passthrough
TLS forRoute
and generate cert/key pair if not provided.Docs: N/a
Testing: TODO(alecmerdler)
Details:
We cannot use
edge
TLS termination with OpenShiftRoutes
because there is not an easy or reliable way of retrieving the cluster CA that is used by the Ingress Operator when it createsRoutes
. This is a problem because Clair needs to trust the HTTPS of whatever storage backend it is fetching image layers from. Instead, we switch to always terminating TLS at the Quay container (which is preferred anyway) and generating a cert/key pair if the user does not provide them in theirconfigBundleSecret
.edge
TLS termination for QuayRoute
and only allowpassthrough
targeting thehttps
portFEATURE_PROXY_STORAGE
is enabled and we are usings3.openshift-storage.svc
and injectingservice-ca.crt
to Quay and config-toolDeployments
ssl.key
+ssl.cert
if not providedReverts work done in: #320 and #315