java: include inner JAR paths in PackageDB #1503
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RTann
force-pushed
the
java-fat-jar-packagedb
branch
from
3f77dd8 to
34bf4b0
Compare
RTann
force-pushed
the
java-fat-jar-packagedb
branch
3 times, most recently
from
1920b11 to
c22d175
Compare
RTann
force-pushed
the
java-fat-jar-packagedb
branch
7 times, most recently
from
6b98f23 to
8f4aade
Compare
RTann
commented
Apr 10, 2025
| @@ -104,7 +104,7 @@ func (tc ScannerTestcase) RunSubset(ctx context.Context, n int) func(*testing.T) | |||
| } | |||
|
|
|||
| if !cmp.Equal(p, g) { | |||
| t.Error(cmp.Diff(p, g)) | |||
| t.Errorf("%v-%v-%v: %v", p.Name, p.RepositoryHint, p.Filepath, cmp.Diff(p, g)) | |||
There was a problem hiding this comment.
This helped a lot in cases where the package names matched. I was going to delete this, but it may be helpful again someday
RTann
commented
Apr 10, 2025
java/packagescanner.go
Outdated
There was a problem hiding this comment.
I didn't bump the version, as it was already bumped in #1467 and there have not been any Claircore releases since
Signed-off-by: RTann <[email protected]> rh-pre-commit.version: 2.3.2 rh-pre-commit.check-secrets: ENABLED
RTann
force-pushed
the
java-fat-jar-packagedb
branch
from
8f4aade to
3ade694
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PackageDB for "inner" JAR files only show the name of the top-level JAR, so it's not clear which dependency must be updated. This updates the PackageDB to include the path of the inner JAR.
An example follows: we'll now show
maven:usr/share/jenkins/jenkins.war:WEB-INF/lib/commons-fileupload-1.4.jarinstead of justmaven:usr/share/jenkins/jenkins.war