This repository has been archived by the owner on Feb 10, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 721
A Simpler Fix to the Streaming Code due to Changes from Twitter on Jan. 13, 2014. #196
Merged
Merged
Changes from 6 commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
128ec04
Ignore .idea files from PyCharm.
adonoho 8631806
Do not send gzip headers for streaming calls. (ref: RouxRC [73efaca])
adonoho ff3ca19
Fix the uri extension by attribute name.
adonoho 25ea832
Change some default attributes and add TwitterHTTPError (ref: RouxRC …
adonoho d488eec
Test for delimiters in the stream and removes them. Add comments.
adonoho 95d4980
Update to use OAuth, take in command line arguments and modify the im…
adonoho d908997
Move the potentially uninitialized values out of the if test.
adonoho ef99d73
Increase the size of the read buffer to be larger than the average tw…
adonoho 7333aa5
Add support for both user and site streams.
adonoho 57aa6d8
Bring HTTP chunk downloading into its own separate method.
adonoho 54555a7
Cosmetic edit
adonoho b8cdd54
Merge branch 'fix-stream' into pr-fix-stream
adonoho c0fc741
Minimize string decoding and move to use a bytearray for the buffer. …
adonoho 02bce53
Cosmetic edits.
adonoho db75126
Merge branch 'fix-stream' into pr-fix-stream
adonoho 2693800
Move recv_chunk() into a stand alone function. Further minimize memor…
adonoho e28a1da
Move variables out of the iterator class and into the generator funct…
adonoho 23dcd46
As Twitter appears to send complete JSON in the chunks, we can simpli…
adonoho 28a8ef6
Further refine socket management.
adonoho cd2fbdf
Bump the version number.
adonoho c20d1a8
Remove all keep-alive delimiters to allow the hangup patch to function.
adonoho 0d92536
Remove socket timeout mutation code.
adonoho b01fa3f
Set a timeout on the main sample stream to test that code path.
adonoho 443e409
Handle HTTP chunks that only contain keep-alive delimiters.
adonoho 3e782f6
Add comments detailing why we can avoid handling certain edge cases i…
adonoho a8880f9
Clarify the comment about edge cases.
adonoho 12bb62d
Merge branch 'fix-stream' into pr-fix-stream
adonoho File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -8,3 +8,4 @@ twitter3.egg-info | |
*~ | ||
dist | ||
build | ||
.idea |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to try it out but I'm worried this should break the delimited=true argument from twitter API by doing this this way