Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Python 3.12 support & fix CI #350

Merged
merged 3 commits into from
Nov 22, 2023
Merged

Add Python 3.12 support & fix CI #350

merged 3 commits into from
Nov 22, 2023

Conversation

sirosen
Copy link
Member

@sirosen sirosen commented Nov 3, 2023

CI is failing because it has picked up 3.12 builds and is running them against one of the tox matrix options which imports dateutil.
Right now, dateutil has a fix for the 3.12-related warning but it is unreleased.

Until the fix is released, we need a patch of some kind to get CI clean again.
The best is to roll forward, rather than pinning things back:

  • update test configs
  • call this official Python 3.12 support (no real changes)
  • add the requisite ignore

- CI
- tox
- requisite ignore for dateutil (at time of writing)
- changelog item
In pytest config -- using `datetime.datetime.utcfromtimestamp` is
important for matching correctly.

For some reason, the previous pattern (as well as the fixed one) works
under a local dev environment with 3.12.
@sirosen sirosen merged commit 5bf9c56 into main Nov 22, 2023
@sirosen sirosen deleted the support-py312 branch November 22, 2023 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant