Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: false positive on swapped words #17762

Merged
merged 1 commit into from
Mar 12, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions tests/unit/packaging/test_typosnyper.py
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@
("dateutil-python", ("swapped_words", "python-dateutil")),
("numpi", ("common_typos", "numpy")),
("requestz", ("common_typos", "requests")),
("python-dateutil", None), # Pass, swapped_words same as original
],
)
def test_typo_check_name(name, expected):
Expand Down
2 changes: 1 addition & 1 deletion warehouse/packaging/typosnyper.py
Original file line number Diff line number Diff line change
Expand Up @@ -381,7 +381,7 @@ def _swapped_words(project_name: str, corpus: set[str]) -> TypoCheckMatch:
# Join the words using `-` to create a new name
reconstructed = "-".join(p)
# If the new name is in the list of popular names, return it
if reconstructed in corpus:
if reconstructed != project_name and reconstructed in corpus:
return "swapped_words", reconstructed

return None
Expand Down