Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store observation kind when prohibiting project names #17731

Merged
merged 3 commits into from
Mar 7, 2025

Conversation

di
Copy link
Member

@di di commented Mar 7, 2025

A step towards pypa/advisory-database#45, this lets us start classifying previously prohibited project names and backfilling observations by delineating whether a name was prohibited via observation or not.

image

@di di requested a review from a team as a code owner March 7, 2025 15:29
@di di requested a review from miketheman March 7, 2025 15:29
Copy link
Member

@miketheman miketheman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than one question, looks good. Once answered, happy to do a quick re-review - smash that "re-request review" button 🔄

@di di requested a review from miketheman March 7, 2025 19:19
@di di merged commit 6fefaa1 into pypi:main Mar 7, 2025
20 checks passed
@di di deleted the prohibited-name-observations branch March 7, 2025 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants