Move unpacking functions from utils.misc to utils.unpacking. #7028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrahunt
added
type: refactor
|
Looks good so far. |
cjerdonek
reviewed
Sep 18, 2019
chrahunt
force-pushed
the
maint/move-unpacking-functions
branch
from
87fc451 to
d1af906
Compare
chrahunt
force-pushed
the
maint/move-unpacking-functions
branch
from
d1af906 to
5a759da
Compare
cjerdonek
approved these changes
Sep 18, 2019
pradyunsg
approved these changes
Sep 18, 2019
|
Merging since everything is green green. :P |
lock
bot
added
the
auto-locked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses a comment in #6861 and part of #6866.