Fix: Patch RPATHs of non-Python extension dependencies #298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n-py extensions (pypa#134) * Adding minimal test wheel based on PR pypa#134 * Separate tests for each change in PR pypa#134 pypa#134 * non-py extension does not show in auditwheel show (ignoring assert) * Confirming tests on macOS * pytest in travis is weirdly triggering a manual test * Sorry! Forgot to install zlib-devel
Codecov Report
@@ Coverage Diff @@
## master #298 +/- ##
=======================================
Coverage 90.99% 91.00%
=======================================
Files 20 20
Lines 1088 1089 +1
Branches 235 235
=======================================
+ Hits 990 991 +1
Misses 55 55
Partials 43 43
Continue to review full report at Codecov.
|
Co-authored-by: Bradley Dice <[email protected]>
|
I'm going to use this PR in my wheel building process until it's merged. Here's a simple script for anyone else that needs it: git clone https://github.com/mayeut/auditwheel.git -b issue136 auditwheel
cd auditwheel
pip install .For some reason, the version appears to be |
auvipy
approved these changes
Mar 18, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves #136, and replaces the open (stalled) PR #139 from @thomaslima (closes #139) and rebase/rework the open PR #283 from @bdice (closes #283)
Summary in #283 is the nice one, so go there for more information.
Tests are much simpler here and still reproduce the issue without the fix of course.
Thanks @bdice, @thomaslima