Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only create a single repaired wheel #284

Closed
wants to merge 1 commit into from

Conversation

lkollar
Copy link
Contributor

@lkollar lkollar commented Feb 10, 2021

When repairing wheels, the result can be compliant with a lower-level
manylinux spec and in this case auditwheel creates another .whl file for
the lower spec as well. This is unnecessary as the lower spec can always
be used on newer compliant platforms. By only producing a single wheel,
we can probably save some space on PyPI as automated build scripts won't
upload multiple copies of the same wheel.

This also avoids an extra call to repair_wheel which can speed things up
for larger libraries.

Closes: #281

When repairing wheels, the result can be compliant with a lower-level
manylinux spec and in this case auditwheel creates another .whl file for
the lower spec as well. This is unnecessary as the lower spec can always
be used on newer compliant platforms. By only producing a single wheel,
we can probably save some space on PyPI as automated build scripts won't
upload multiple copies of the same wheel.

This also avoids an extra call to repair_wheel which can speed things up
for larger libraries.
@lkollar
Copy link
Contributor Author

lkollar commented Feb 10, 2021

I haven't added a flag for this because I don't think there is any point in retaining the previous behaviour, but I might be missing something. Anybody see any problems with this?

@codecov
Copy link

codecov bot commented Feb 10, 2021

Codecov Report

Merging #284 (7963262) into master (22c8451) will increase coverage by 0.34%.
The diff coverage is 77.77%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #284      +/-   ##
==========================================
+ Coverage   89.03%   89.37%   +0.34%     
==========================================
  Files          20       20              
  Lines        1058     1064       +6     
  Branches      226      226              
==========================================
+ Hits          942      951       +9     
+ Misses         69       65       -4     
- Partials       47       48       +1     
Impacted Files Coverage Δ
auditwheel/main_repair.py 77.35% <77.77%> (-3.50%) ⬇️
auditwheel/main_show.py 64.70% <0.00%> (-5.89%) ⬇️
auditwheel/wheel_abi.py 96.00% <0.00%> (-2.41%) ⬇️
auditwheel/lddtree.py 92.90% <0.00%> (+0.70%) ⬆️
auditwheel/policy/__init__.py 100.00% <0.00%> (+1.85%) ⬆️
auditwheel/wheeltools.py 89.31% <0.00%> (+2.29%) ⬆️
auditwheel/policy/external_references.py 97.61% <0.00%> (+4.76%) ⬆️
auditwheel/main_addtag.py 78.94% <0.00%> (+13.15%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 22c8451...8672e8a. Read the comment docs.

@mayeut
Copy link
Member

mayeut commented Feb 10, 2021

@lkollar,

I will try to get a little history on the why because I know this has been reported and discussed before.
I fully agree with the fact that only one wheel should be produced however, I do find the information of the policy used to repair the wheel useful and I think there might be a way not to lose it.
I will get back here with my findings over the week-end.

@mayeut
Copy link
Member

mayeut commented Feb 14, 2021

@lkollar,

I left some comment in #281 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add flag to prevent multiple wheel repairs
2 participants