-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wip: support native ether #1262
Conversation
Hey @hexyls can you include Ether into the UI so I can test it? for the time being, we should include both tokens Ether/Wrapped Ether in the the asset balance dropdown so the users can do whatever they want. So only if the user picks native Ether, we need to go the gnosis safe batches all actions together route. |
Funding with native ether should work at this point but does not. Some notes:
Will continue to explore... |
Yep there is a problem with the MultiSend contract. Again it is the same issue that both Gnosis Safe v1.1.1 and the current Proxy factory have. I deployed a new MultiSend contract on Rinkeby and was able to get multisend with ether wrapping working. However the conversion of tx values to numbers in contract-proxy-kit is still a problem. |
Today I monkey patched the cpk library to fix the transaction value encoding issue. Once this proposal passes to add / index WETH markets on Rinkeby we should be ready to test market creation in native ether. I have actually made a successful transaction that should have created a market but it was not indexed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!
@@ -67,6 +70,8 @@ interface KnownTokenData { | |||
order: number | |||
} | |||
|
|||
export const pseudoNativeAssetAddress = '0xEeeeeEeeeEeEeeEeEeEeeEEEeeeeEeeeeeeeEEeE' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Out of curiousity, is there any particular reason you capitalized the address like this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I copied this from the 0x Project I think 🤔 and this is the checksum of that address, for us we could use any value here though cause we don't use the address in any transactions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
I found issues with the asset dropdown ( #1499 ) , but should be fixed in a separat PR! Looks good to me! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good ! Tested xdai markets they work good, native eth works great also!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Closes #676
Includes native asset support for ethereum (mainnet, rinkeby), sokol, and xdai.
xDAI
Replaces: #1464
PR does not include verification, we can add that later once the kleros/curate-xdai subgraph is up.
Name: xDai
RPC: https://rpc.xdaichain.com/
Chain ID: 100
Symbol: xDai
Block explorer: https://blockscout.com/poa/xdai