fix: handle unregistered student as KO message

presentium · Sep 3, 2024 · 4b19a37 · 4b19a37
1 parent 3eaf274
commit 4b19a37
Showing 1 changed file with 7 additions and 1 deletion.
diff --git a/src/main/java/ch/presentium/backend/rpc/DeviceRpcService.java b/src/main/java/ch/presentium/backend/rpc/DeviceRpcService.java
@@ -1,5 +1,6 @@
 package ch.presentium.backend.rpc;
 
+import ch.presentium.backend.api.exception.ObjectNotFoundException;
 import ch.presentium.backend.business.service.EnrollmentService;
 import ch.presentium.backend.business.service.PresenceService;
 import java.util.UUID;
@@ -47,7 +48,12 @@ public Mono<GenericResponse> studentPresence(Mono<PresenceStudent> request) {
         return request
             .publishOn(Schedulers.boundedElastic())
             .map(req -> {
-                presenceService.addPresence(req.getCardId(), UUID.fromString(req.getSessionId()));
+                try {
+                    presenceService.addPresence(req.getCardId(), UUID.fromString(req.getSessionId()));
+                } catch (ObjectNotFoundException e) {
+                    return GenericResponse.newBuilder().setStatus("KO").setMessage("Unregistered student").build();
+                }
+
                 return GenericResponse.newBuilder().setStatus("OK").setMessage("Student presence verified").build();
             });
     }