[pull] master from melonjs:master #308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
…ocha and puppeteer
Replace test framework with vitest
- add the option to use a destroy() method when pushed back into the pool (to mimic the legacy pool implementation) - rename internal import from pool to legacy_pool (internally only) - migrate tween objects to the new pool implementation - pass color arguments directly to the colorPool getter in Camera2d - export createPool directly under pools
…to the pool get() method
as they can use different canvas attributes
… TS error when overrriding those methods)
…c object `destroy` method triggered when an object is removed from the scene
also fix the legacy pool system not reporting instances from the new pool implementation (temporary while the 2 co-exists)
…oes not break hmr
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )