Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pilcom proof fail test functions (reapprove) #2574

Draft
wants to merge 2 commits into
base: split-with-backend
Choose a base branch
from

Conversation

qwang98
Copy link
Collaborator

@qwang98 qwang98 commented Mar 21, 2025

Incorrectly merged to a non-main branch previously, so needs a reapproval.

Depends on #2535 and #2557. Split assert_proofs_fail_for_invalid_witnesses_pilcom into assert_proofs_fail_for_invalid_witnesses_pilcom_composite and assert_proofs_fail_for_invalid_witnesses_pilcom_monolithic. These two APIs are needed because we might generate different witnesses for pilcom composite vs pilcom monolithic under two scenarios:

  1. The two backends can have different witnesses to start with. This hasn't been an issue because most of our test cases are very simple machines.
  2. After updates in PoC for two passes of pilopt #2535, if we eventually implement different optimizations for the two different backends, they might compute two different witnesses.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant