Split compile function and use interpreter for large code. #2569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chriseth
force-pushed
the
split_compile_fun
branch
from
0f29393 to
18b2954
Compare
chriseth
changed the title
pacheco
reviewed
Mar 20, 2025
| variable::Variable, | ||
| witgen_inference::CanProcessCall, | ||
| }; | ||
|
|
||
| const MAX_COMPILED_CODE_SIZE: usize = 500; |
There was a problem hiding this comment.
might be good to leave a small comment here for usage/context
| // Use the compiler for goldilocks with at most MAX_COMPILED_CODE_SIZE statements and | ||
| // the interpreter otherwise. | ||
| let interpreted = matches!(T::known_field(), Some(KnownField::GoldilocksField)) | ||
| || (code_size(&result.code) > MAX_COMPILED_CODE_SIZE && !has_prover_function_call); |
There was a problem hiding this comment.
has_prover_function_call should not be tested here due to the following if
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This first derives the code and then makes the decision of whether or not to use the interpreter based on the derived code.