[POA-3109] Handle panic while stopping apidump process while daemonset exit #90
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes changes to prevent the agent from going into a panic state while closing the apidump process during the daemonset process shutdown and other changes.
Problem:
StopApiDumpProcess
, we are checking if the process is already in the final state to avoidStopApiDumpProcess
being called multiple times.StopApiDumpProcess
can be called multiple times which will send signal to already stopped channel hence causing program to go to panic state.Changes:
Improvements to state handling:
changePodTrafficMonitorState
to prevent state changes if the pod is already in a final state.changePodTrafficMonitorState
.Other naming changes:
StopApiDumpProcess
toSignalApiDumpProcessToStop
for better clarity on its purpose.isEndState
toisTrafficMonitoringInFinalState
for better readability and consistency.