Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify WIR Bank PDF-Importer to support VIAC Invest transactions #4512

Merged
merged 1 commit into from
Feb 7, 2025

Conversation

gh-nw-pp
Copy link
Contributor

@gh-nw-pp gh-nw-pp commented Feb 4, 2025

VIAC launched a new product (VIAC Invest), which uses a PDF format that is very similar to its existing product / WIR Bank PDFs

@Nirus2000 Nirus2000 self-requested a review February 5, 2025 17:15
@Nirus2000 Nirus2000 added the pdf label Feb 5, 2025
@Nirus2000 Nirus2000 self-assigned this Feb 6, 2025
@Nirus2000
Copy link
Member

Nirus2000 commented Feb 6, 2025

Hello @gh-nw-pp

thank you very much for this pull request. 👍🏻
To ensure a good overview and further support of different banks and brokers, it is important to keep the structure of the importers. (Contributing rules)
Importers are created for each supported bank and/or broker.
Therefore, a separate PDF importer must be created for VIAG Invest AG. If you need help, please let me know

Greetings
Alex

@Nirus2000 Nirus2000 marked this pull request as draft February 6, 2025 19:52
@gh-nw-pp
Copy link
Contributor Author

gh-nw-pp commented Feb 6, 2025

Hi @Nirus2000,

I understand your concern, but VIAC is part of WIR Bank (check the VIAC product page in the WIR Bank website, or check the Impressum on the VIAC website, which contains WIR Bank).

The "VIAC Säule 3a" ("Säule 3a" is a private pension plan in Switzerland) PDFs are already processed using the WIR Bank PDF importer, so I just added support for the "VIAC Invest" PDFs as well.
I don't have access to any PDFs issued by WIR Bank directly, but I assume, that they are (almost) identical. But for some reason, the wording on the PDFs for VIAC Invest is slightly different ("Kauf" vs "Zeichnung" or "Verkauf" vs "Rücknahme"), plus the bank identifer/header of the PDF differs:
grafik

Even though WIR Bank and VIAC Invest AG are two different entities, I would argue, that it would make sense to keep the same PDF importer for both of them. But if you insist, I can create a completely new PDF importer for VIAC Invest, which would pretty much be copy-paste of the WIR Bank importer.

@Nirus2000 Nirus2000 removed their request for review February 7, 2025 06:43
@Nirus2000 Nirus2000 marked this pull request as ready for review February 7, 2025 06:44
@Nirus2000 Nirus2000 merged commit 777e163 into portfolio-performance:master Feb 7, 2025
2 checks passed
@Nirus2000
Copy link
Member

Okay. you've convinced me :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants