Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow '.' from numpad as Spanish decimal separator #4508

Merged

Conversation

mierin12
Copy link
Contributor

@mierin12 mierin12 commented Feb 2, 2025

Issue : https://forum.portfolio-performance.info/t/decimal-separator-on-french-keyboard/28939/20
Comment : #4143 (comment)

Hello, this is a proposition to allow the numpad '.' to be detected and replaced by the Spanish decimal separator (','), as per the above comments.
To be noted:

  • '.' is the Spain thousands separator, but thousands separator are not expected to be typed by users, right ?
  • Some Spanish country (Mexico, Ecuador etc) already use '.' as decimal separator (as opposed to Spain). However this change will replace numpad '.' by their decimal separtor ('.') so not impact I believe.

Capture d’écran 2025-02-01 003322
Capture d’écran 2025-02-01 003411

Proposition of rename for the method as it would no longer be only French related.

@buchen buchen merged commit 1b7d4f4 into portfolio-performance:master Feb 2, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants