feat: Add RoundMode
for Decimal and Float
#22248
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #21800 (though as @orlp mentioned there are theoretically more round modes to add)
Current Problem⚠️
round
expression has nomode
and is inconsistentDecimal
: uses "half to even"Float
: uses "half away from zero"PR Solution 🍀
Decimal
: implement "half away from zero"Float
: implement "half to even"Example
Open
@orlp @wence-
sorry for creating another PR (old: #21883). I was overwhelmed and stuck in merge/rebase hell.
I implemented your requests. Please have a look 🤓