refactor(rust): Actually set the consume token in the file reader morsel sender #22117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Draft

nameexhaustion wants to merge 2 commits into pola-rs:main from nameexhaustion:consume-token

Collaborator

nameexhaustion commented Apr 4, 2025 •

edited

Loading

there's not much point having the wait_group.wait().await otherwise. silly mistake 😄.

~~As a side note, this may not have any observable impact.~~ nvm.. something is deadlocking 🤔

nameexhaustion added 2 commits

April 4, 2025 13:54

5aa9e1a

a24ec93

github-actions bot added internal rust labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

ritchie46 Awaiting requested review from ritchie46 ritchie46 will be requested when the pull request is marked ready for review ritchie46 is a code owner

orlp Awaiting requested review from orlp orlp will be requested when the pull request is marked ready for review orlp is a code owner

c-peters Awaiting requested review from c-peters c-peters will be requested when the pull request is marked ready for review c-peters is a code owner

At least 1 approving review is required to merge this pull request.

Labels