Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed some immoral inconsistencies #1321

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

CondoSlime
Copy link
Contributor

Immoral was previously removed on game load if your species didn't have the evil trait. This was presumably an ancient leftover from a patch that accidentally added immoral onto every race. It should not be necessary anymore.
This code caused issues as it also removed immoral from non-evil demons and celestial Nephilim upon game load. Both races that are possible to play with standard gameplay.

Immoral no longer added to wendigo on game load during Christmas period.
During Christmas, Wendigos are reskinned as Krampus and get three additional traits, however for some reason, after a game load, the immoral trait is added if you don't have it yet, even if you mutated it out or didn't even start the run as Krampus. This was the only event trait that works like that.

Immoral no longer removed when race is not evil.
Immoral no longer added to wendigo on game load during christmas period.
@Kelenius
Copy link
Contributor

For some context, this is the commit that added this block: 37a94c2. It looks like global.race['immoral'] = 1; in main.js was adding immoral erroneously, and the block that removes it was added to remove the trait from the race if the game is already started.

The part about Krampus was added in 14e45c1, because they are supposed to have immoral without evil. I think that part was added to do the opposite, add it back to ongoing Krampus games that had it erroneously removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants