Refactor alchemy addSpell/subSpell loops into linear for better performance #1315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alchemy addSpell/subSpell code loops over the whole keyMultiplier one at a time, writing to Vue reactive properties that are expensive to write to much more often than necessary.
Since mana generation can get really high at very high levels of prestige, this ends up being very slow when assigning/reassigning endgame levels of mana at once (potentially many millions). This reduces the usage by the maximum amount that can be assigned per click (so a ~25000x performance improvement if ctrl-alt-shift-clicking).