Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update homepage on PyPI. #340

Merged
merged 3 commits into from
May 1, 2019
Merged

Update homepage on PyPI. #340

merged 3 commits into from
May 1, 2019

Conversation

shammamah-zz
Copy link
Contributor

@shammamah-zz shammamah-zz commented May 1, 2019

Closes #339

Before merging

@shammamah-zz shammamah-zz temporarily deployed to dash-bio-test-pr-340 May 1, 2019 03:26 Inactive
@shammamah-zz shammamah-zz requested a review from mkcor May 1, 2019 03:27
@shammamah-zz shammamah-zz temporarily deployed to dash-bio-test-pr-340 May 1, 2019 03:34 Inactive
Copy link
Contributor

@mkcor mkcor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It takes a new entry in CHANGELOG.md to document the difference between version 0.0.9 and version 0.0.10.

@shammamah-zz
Copy link
Contributor Author

@mkcor OK -- added an entry. I'm wondering if we need to add CHANGELOG entries for every single patch (that seems a little excessive, especially when it's something as minor as this that doesn't affect how the package behaves at all).

@shammamah-zz
Copy link
Contributor Author

For example, the CHANGELOG for Dash (https://github.com/plotly/dash/blob/master/CHANGELOG.md) is only updated for minor versions.

@mkcor
Copy link
Contributor

mkcor commented May 1, 2019

Ok. I think you're misinterpreting what I said. It's the other way around.

I'm only asking for a CHANGELOG entry because you bumped up the version number. Personally, I would have made this tiny change without changing versions... and all this (including WIP docs) would have been smoother and faster.

But if you go from 0.0.9 to 0.0.10 (which I don't think was necessary, I actually think it's a bit odd), somehow you have to justify it... right? I still don't understand why you bumped version number to 0.0.10, but now that you did, I'm trying to make it work somehow.

@shammamah-zz
Copy link
Contributor Author

Actually, you do have to bump the version number to edit the metadata. See discussion here: pypi/warehouse#2170 (comment)

@shammamah-zz
Copy link
Contributor Author

More info here: https://mail.python.org/pipermail/distutils-sig/2017-December/031826.html

@mkcor
Copy link
Contributor

mkcor commented May 1, 2019

Looking at the CHANGELOG for Dash, it doesn't seem related to anything major/minor/patch/rc. It looks like it's updated whenever there's a version updated, whether minor or patch or anything.

@shammamah-zz
Copy link
Contributor Author

Ah, you're correct! Didn't scroll down far enough :)

@mkcor
Copy link
Contributor

mkcor commented May 1, 2019

That's super interesting, thanks for sharing. But here I'm not really arguing about whether to increment versions or not. Rather, I'm arguing that if you do so, then you want to document it.

Do you mind rerunning CI to get those tests to pass?

@shammamah-zz shammamah-zz merged commit 04685b2 into master May 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dash Bio homepage is wrong on PyPI
2 participants