Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MRG] get_document_topic Tests and Documentation changes. #741

Merged
merged 1 commit into from
Jun 22, 2016
Merged

[MRG] get_document_topic Tests and Documentation changes. #741

merged 1 commit into from
Jun 22, 2016

Conversation

bhargavvader
Copy link
Contributor

@bhargavvader bhargavvader commented Jun 10, 2016 •
edited
Loading

@tmylk , I've changed the tests such that it's less strict, it just looks for the presence of topic_0 in the list of most probable topics.
@graychan changed minimum_phi_probabilities to minimum_phi_values.

Edit: python 2.7 fails because of a time-out.

@bhargavvader bhargavvader mentioned this pull request Jun 10, 2016
Closed
@bhargavvader
Copy link
Contributor Author

bhargavvader commented Jun 22, 2016 •
edited
Loading

@tmylk , any reason this hasn't been merged?

Edit: just noticed #748 which would help test cases like this. Seems like that is the reason this hasn't been merged yet, which makes sense :)

@tmylk tmylk merged commit f283ea4 into piskvorky:develop Jun 22, 2016
@bhargavvader bhargavvader deleted the TopicWord_Tests branch February 23, 2017 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@tmylk tmylk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bhargavvader @tmylk