-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce memory consumption of summarizer #2298
Merged
menshikh-iv
merged 15 commits into
piskvorky:develop
from
horpto:summarization-refactoring
Jan 18, 2019
Merged
Changes from 12 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
a0523f6
reduce memory consumption
horpto 7273b05
fix build
horpto 0d606fa
Merge remote-tracking branch 'upstream/develop' into summarization-re…
horpto a7d21c2
add deleting null-weighted edge
horpto 3b2c818
Merge remote-tracking branch 'upstream/develop' into summarization-re…
horpto ae39b0b
iterate over bm25 weights
horpto c04ed73
fix build
horpto 9f0259a
fix wrong example
horpto bb9365c
add method iter_graph in Graph
horpto b56a811
add index argument in SyntacticUnit
horpto 70bd79a
fix logging messages
horpto 008d5cb
refactor graph - remove unnecessary parts
horpto 4549a86
Add test and fix typos
horpto f6b68bf
fix built (flake8)
horpto b850ff4
add printing of documents number
horpto File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In that case
len(scores) <= self.corpus_size
, why?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because it's actually quite sparse array, isn't it?
In
summarizer._set_graph_edge_weights
such documents with little weight will be dropped anyway, so there is no reason to waste extra memory. And what's more, if we are needed a dense array we can uncompactify this bow.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't get, how we understand ids of documents that have 0 scores in that case?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Easy. Like words with 0 weight in bow. We have ids of docs with not zero weight. They are saved in bag-of-docs (I should rename function name part from bow - bag-of-weights to bod - bag-of-docs). If doc id isn't in bag-of-docs, so weight of doc is 0.